Shivani, this looks good, only one comment below.
On Fri, Jan 22, 2016 at 09:59:07PM +0530, Shivani Bhardwaj wrote:
> @@ -51,6 +57,8 @@ int main(int argc, char *argv[])
> print_err("OOM");
>
> nftnl_expr_set_u32(ex, NFTNL_EXPR_MASQ_FLAGS, 0x1234568);
> + nftnl_expr_set_u32(ex, NFTNL_EXPR_MASQ_REG_PROTO_MIN, 0x1234568);
> + nftnl_expr_set_u32(ex, NFTNL_EXPR_MASQ_REG_PROTO_MAX, 0x1234568);
I think the tests are more effective if you set different values, ie.
nftnl_expr_set_u32(ex, NFTNL_EXPR_MASQ_FLAGS, 0x12345678);
nftnl_expr_set_u32(ex, NFTNL_EXPR_MASQ_REG_PROTO_MIN, 0x45671234);
nftnl_expr_set_u32(ex, NFTNL_EXPR_MASQ_REG_PROTO_MAX, 0x87654321);
Beware that my kernel patch is only compile tested.
And please follow up with the nftables patch, let me know if you have
questions with it.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
