stéphane bryant <stephane.ml.bryant@xxxxxxxxx> wrote: Please don't top-post, thanks. > Regarding the entire L2 header attribute. I assume it would be a > separate attribute from the existing NFQA_HWADDR? Yes, it would just contain mac header start to skb->data, i.e. without VLAN header. VLAN header would go into a new attribute too. > Or would it make sense > to collapse these 2 into one (potentially with helpers to access each > relevant field) to avoid duplicating information (and redundancy, and > potential discrepancies)? Yes but we cannot do it due to backwards compatibility. We *can* omit NFQA_HWADDR in the family == NFPROTO_BRIDGE case of course. Thanks for working on this, Florian -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
