Stephane Bryant <stephane.ml.bryant@xxxxxxxxx> wrote: > From: stephane <stephane.ml.bryant@xxxxxxxxx> > > For bridge packets queued to userspace, this uses the skb tci info > to reinstate the VLAN header, and conversely parses and removes it > to fill the tci info on the way back. > - * it gets copied in > - */ > mac_header_len = > (int)(entskb->data - skb_mac_header(entskb)); > - skb_push(entskb, mac_header_len); > + if (skb_vlan_tag_present(entskb)) > + vlan_len = VLAN_HLEN; I wondered if we could use the saveroute and reroute hooks in the nf afinfo to perform the push/pull. It would keep the bridge specific parts out of the generic code. Thanks for working on this! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html