Re: [PATCH v3] extensions: libxt_connmark: Add translation to nft

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 25, 2015 at 08:09:40PM +0530, Shivani Bhardwaj wrote:
> On Fri, Dec 25, 2015 at 5:43 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > The size of unsigned long depends on the architecture, so this code
> > will not work correctly.
> >
> > You have to add a connmark_mt_xlate_v0() and connmark_mt_xlate_v1(),
> > in each of these functions you have to cast data to the right
> > structure layout.
> >
> > Thanks.
> 
> Thanks for explaining. I understand it now but why is this patch
> wrong? I have used connmark_xlate() and connmark_mt_xlate() in their
> respective places. Do I still get it wrong?
> 
> I'm correcting this mistake for MARK.

This patch correctly handles what I indicated above, but MARK is still
wrong.

So I'm applying this patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux