On Tue, Dec 22, 2015 at 01:47:57PM +0100, Arturo Borrero Gonzalez wrote: > On 21 December 2015 at 18:35, Shivani Bhardwaj <shivanib134@xxxxxxxxx> wrote: > > > > +static void nflog_print_xlate(const struct xt_nflog_info *info, > > + char *prefix, struct xt_buf *buf) > > +{ > > + if (info->prefix[0] != '\0') > > + xt_buf_add(buf, "%slog prefix \\\"%s\\\" ", > > + prefix, info->prefix); > > + if (info->group) > > + xt_buf_add(buf, "%slog group %u ", prefix, info->group); > > if info->group is not set, you should probably default to 0, since > this group info is mandatory in nftables to consider this logging the > same type of NFLOG (ie, use nfnetlink_log). > > For reference, see: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/net/netfilter/nft_log.c#n67 Thanks Arturo. Please Shivani, address Arturo's feedback and send me an incremental patch to fix this. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html