On 12/07/2015 02:29 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/07/2015 01:13 PM, Nikolay Borisov wrote:
>
>> Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}:
>
> Double quotes please, that's what scripts/checkpatch.pl enforces now.
>
>> Register pernet in first place') reorganised the initialisation
>> order of the pernet_subsys to avoid "use-before-initialised"
>> condition. However, in doing so the cleanup logic in nfnetlink_queue
>> got botched in that the pernet_subsys wasn't cleaned in case
>> nfnetlink_subsys_register failed. This patch adds the necessary
>> cleanup routine call.
>>
>> Fixes: 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: Register
>> pernet in first place')
>
> Likewise.
I will resend it with proper quotes (even though I think this is a minor
issue) but I'd like to first gather some review feedback.
Also I dunno if this should be marked for stable.
>
>>
>> Signed-off-by: Nikolay Borisov <kernel@xxxxxxxx>
>
> [...]
>
> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
