Re: [RFC PATCH nft] proto: add missing fields for ARP with IPv4/Ethernet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick McHardy <kaber@xxxxxxxxx> wrote:
> If we agree to do it like this for now, what about naming? I don't like the
> token names very much, but I also want to avoid excessively long tokens.
> If someone has a nice reasonable suggestion please let me know.

> +%token SHA			"sha"

shwaddr?  Or just saddr.

> +%token THA			"tha"

thwadddr, or taddr.

> +%token SIP			"sip"
> +%token TIP			"tip"

rfc826 calls these ar$spa ar$tpa ('source/target protocol address').
Perhaps 'srcip' and 'targetip'?

I don't think we should care about more generic
term since ...

> +		[ARPHDR_SIP]		= ARPHDR_IP_ADDR("sip", ar_sip),

... we expect an IP address anyway.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux