Re: [PATCH nf-next 3/6] netfilter: nf_tables: disable old tracing if listener is present

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick McHardy <kaber@xxxxxxxxx> wrote:
> Ok here's might current state. I've added an output filter and defined
> output ordering, so we can surpress some fields and order the remaining
> ones the way we want. I've also added redundant payload dependency
> elimination.
> 
> Example output looks like this:
> 
> trace id 85060d00 arp packet: iif ens3 ether saddr 63:f6:4b:00:54:52 ether daddr c9:4b:a9:00:54:52 arp operation reply arp sha 63:f6:4b:00:54:52 arp sip 192.168.122.1 arp tha c9:4b:a9:00:54:52 arp tip 192.168.122.84
> 
> trace id 853ff400 ip packet: iif ens3 ether saddr 63:f6:4b:00:54:52 ether daddr c9:4b:a9:00:54:52 ip saddr 192.168.122.1 ip daddr 192.168.122.84 ip tos 16 ip ttl 64 ip id 38325 ip length 60 tcp sport 46156 tcp dport 10000
> 
> trace id 853ffc00 ip packet: oif ens3 ip saddr 192.168.122.84 ip daddr 192.168.122.1 ip tos 16 ip ttl 64 ip id 51655 ip length 40 tcp sport 10000 tcp dport 46156
> 
> If people are happy this way I'll start getting it into final shape.

Please do, looks great!

But note that I'm still busy with v2 of the libnftnl and kernel parts,
there will be minor changes there.

1. VLAN_TAG attr will be removed, I'll insert vlan header after ethernet
one in the LL_HEADER payload.
2. IIF, OIF etc attributes will be removed.  Instead, I plan to reuse
meta keys for this in a nested TRACE_META attribute.

Not sure yet how the libnftnl part will look like, I'd prefer to reuse
meta decoding parts that we have in libnftnl already
(my thinking was that if we'd want e.g. secmark later we could
 do so more easily if we'd just reuse meta key values).

3. PACKET message type has been removed.  Kernel will insert the HEADER
payloads in the first message sent from each do_chain invocation.

I think this will not interfere with your patch too much.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux