Re: [PATCH nf-next 3/6] netfilter: nf_tables: disable old tracing if listener is present

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.11, Patrick McHardy wrote:
> On 25.11, Florian Westphal wrote:
> > Hmm, I think it actually increases readability, as all the other lines
> > you quoted above are a lot shorter the ip saddr part is a lot more
> > visible.
> 
> They are actually still missing some minor parts from the original output :)
> 
> But if we want to shorten them, I would suggest f.i. to not repeat the
> devices on every line. It seems to logically belong to the "packet" part,
> same as vlan id. I guess the only thing we actually need to repeat is the
> mark since that might change while we're within the ruleset.

Actually thinking more about this, we might want to send a new "packet"
message whenever we enter nft_do_chain(). At that point the packet has been
processed by other parts of the network stack since the last "packet"
message and it might be helpful to know in which ways it has changed.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux