On 24.11, Florian Westphal wrote: > +void nf_tables_trace_notify(const struct nft_pktinfo *pkt, > + const struct nft_chain *chain, > + const struct nft_rule *rule, > + u32 verdict, > + enum nft_trace_types type) > +{ > + struct nfgenmsg *nfmsg; > + struct nlmsghdr *nlh; > + struct sk_buff *skb; > + unsigned int size; > + int event = (NFNL_SUBSYS_NFTABLES << 8) | NFT_MSG_TRACE; > + > + if (!nfnetlink_has_listeners(pkt->net, NFNLGRP_NFTABLES)) > + return; > + > + /* Unlike other notifiers we need GFP_ATOMIC so use actual size > + * needed instead of NLMSG_GOODSIZE. > + */ > + size = nlmsg_total_size(sizeof(struct nfgenmsg)) > + + nla_total_size(sizeof(__be32)) /* trace type */ > + + nla_total_size(NFT_TABLE_MAXNAMELEN) > + + nla_total_size(NFT_CHAIN_MAXNAMELEN) > + + nla_total_size(sizeof(u32)) /* iif */ > + + nla_total_size(sizeof(u32)) /* oif */ > + + nla_total_size(sizeof(u32)) /* id */ > + + nla_total_size(sizeof(u32)) /* mark */ > + + nla_total_size(sizeof(u32)) /* verdict */ > + + nla_total_size(sizeof(__be64)); /* rule handle */ Minor style issue: we got rid of putting the operator on the next line everywhere. Let's keep this consistent. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html