On 24.11, Pablo Neira Ayuso wrote: > On Tue, Nov 24, 2015 at 11:27:07AM +0100, Florian Westphal wrote: > > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > Do you think we can place all this new netlink code in > > > net/netfilter/nf_tables_trace.c ? So we leave in the core file only > > > our classifier engine. > > > > > > I like the attribute definition rename in nf_tables.h, but this code > > > we can probably place it away from here. > > > > Ok, I'll see if this is doable without exporting half a dozen of > > symbols. > > If you place this in this core, we should need to export any symbol. > > nf_tables-objs += nf_tables_core.o nf_tables_api.o nf_tables_trace.o > > And I would expect probably only functions to enable/disabling tracing > and to notify the trace via netlink. I think we can also avoid the enable/disable exports. Having meta optional doesn't make too much sense to me, it provides very fundamental features like interface matching which I don't think anyone can reasonably disable. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
