Hi Tejun, On 11/21/2015 05:13 PM, Tejun Heo wrote: > This is v3 of the xt_cgroup2 patchset. Changes from the last take are > > * Folded cgroup2 path matching into xt_cgroup as a new revision rather > than a separate xt_cgroup2 match as suggested by Pablo. > > * Refreshed on top of Nina's net_cls dynamic config update fix patch. > I included the fix patch as part of this series to ease reviewing. I started to play with your patches and was greeted by this: [ 3.217648] systemd[1]: tmp.mount: Directory /tmp to mount over is not empty, mounting anyway. [ 3.224665] BUG: spinlock bad magic on CPU#1, systemd/1 [ 3.225653] lock: cgroup_sk_update_lock+0x0/0x60, .magic: 00000000, .owner: systemd/1, .owner_cpu: 1 [ 3.227034] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #195 [ 3.227862] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014 [ 3.228906] ffffffff834a2160 ffff88007c043ad0 ffffffff81551edc ffff88007c028000 [ 3.229512] ffff88007c043af0 ffffffff81136868 ffffffff834a2160 ffff88007aff5940 [ 3.230105] ffff88007c043b08 ffffffff81136b05 ffffffff834a2160 ffff88007c043b20 [ 3.230716] Call Trace: [ 3.230906] [<ffffffff81551edc>] dump_stack+0x4e/0x82 [ 3.231289] [<ffffffff81136868>] spin_dump+0x78/0xc0 [ 3.231642] [<ffffffff81136b05>] do_raw_spin_unlock+0x75/0xd0 [ 3.232039] [<ffffffff81bced77>] _raw_spin_unlock+0x27/0x50 [ 3.232431] [<ffffffff819b1848>] update_classid_sock+0x68/0x80 [ 3.232836] [<ffffffff812855c1>] iterate_fd+0x71/0x150 [ 3.233197] [<ffffffff819b1757>] update_classid+0x47/0x80 [ 3.233571] [<ffffffff819b17d4>] cgrp_attach+0x14/0x20 [ 3.233929] [<ffffffff81188951>] cgroup_taskset_migrate+0x1e1/0x330 [ 3.234366] [<ffffffff81188b95>] cgroup_migrate+0xf5/0x190 [ 3.234747] [<ffffffff81188aa5>] ? cgroup_migrate+0x5/0x190 [ 3.235130] [<ffffffff81188da6>] cgroup_attach_task+0x176/0x200 [ 3.235543] [<ffffffff81188c35>] ? cgroup_attach_task+0x5/0x200 [ 3.235953] [<ffffffff8118922d>] __cgroup_procs_write+0x2ad/0x460 [ 3.236377] [<ffffffff81188fde>] ? __cgroup_procs_write+0x5e/0x460 [ 3.236805] [<ffffffff81189414>] cgroup_procs_write+0x14/0x20 [ 3.237205] [<ffffffff81185ae5>] cgroup_file_write+0x35/0x1c0 [ 3.237600] [<ffffffff812e25e1>] kernfs_fop_write+0x141/0x190 [ 3.237998] [<ffffffff81265e78>] __vfs_write+0x28/0xe0 [ 3.238361] [<ffffffff811292c7>] ? percpu_down_read+0x57/0xa0 [ 3.238761] [<ffffffff81268b04>] ? __sb_start_write+0xb4/0xf0 [ 3.239154] [<ffffffff81268b04>] ? __sb_start_write+0xb4/0xf0 [ 3.239554] [<ffffffff812665ec>] vfs_write+0xac/0x1a0 [ 3.239930] [<ffffffff81285fa6>] ? __fget_light+0x66/0x90 [ 3.240308] [<ffffffff81266f09>] SyS_write+0x49/0xb0 [ 3.240656] [<ffffffff81bcfb32>] entry_SYSCALL_64_fastpath+0x12/0x76 I am using a Fedora 23 host with systemd.unified_cgroup_hierarchy=1. The config is available here: http://monom.org/cgroup/config-review-xt_cgroup2 Probably completely rubbish, because it's my random test config. cheers, daniel -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
