On Mon, Nov 16, 2015 at 06:03:25PM +0100, Pablo Neira Ayuso wrote: > On Mon, Nov 16, 2015 at 03:22:21PM +0100, Arturo Borrero Gonzalez wrote: > > On 16 November 2015 at 12:17, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > On Fri, Nov 13, 2015 at 11:59:35AM +0100, Arturo Borrero Gonzalez wrote: > > >> v2: change functions definitions to static inline if no BUILD_SYSTEMD, > > >> and set watchdog variables as static. > > >> > > >> v3: add runtime systemd configuration. Report warnings. > > > > > > One more question: > > > > > > This is checking for 'libsystemd >= 227' > > > > > > Is this library version really required? Or it is simply that you have > > > set to the most recent version for some reason? > > > > 227 is the version I've tested. Previous versions may not work. > > > > For example, I remember the library being split in several small > > libraries and then mixed into this libsystemd, thus changing some > > headers and include paths. > > > > Also, I simply ignore what is the behaviour of the watchdog stuff > > previous to 227, it seems a recent thing. > > > > What are your concerns? > > I would like not to see many ifdefs in the conntrack-tools tree just > because they update interfaces too frequently. Could you check at > their history record to see how they have been performing on that > front so far? Arturo, I'm going to push this into master. I have just mangled the configure.ac part of your patch here so the default behaviour is that you have to explicitly indicate --enable-systemd support if you want this. We can revisit this later on to change the default. OK? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
