Re: [PATCH net] netfilter: ipt_rpfilter: remove the nh_scope test in rpfilter_lookup_reverse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Xin Long <lucien.xin@xxxxxxxxx> wrote:
> --accept-local  option works for res.type == RTN_LOCAL, which should be from
> the local table, but there, the fib_info's nh->nh_scope = RT_SCOPE_NOWHERE
> ( > RT_SCOPE_HOST). in fib_create_info().
> 
> 	if (cfg->fc_scope == RT_SCOPE_HOST) {
 
> but in our rpfilter_lookup_reverse():
> 
> 	if (dev_match || flags & XT_RPFILTER_LOOSE)
> 		return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
> 
> if nh->nh_scope > RT_SCOPE_HOST, it will fail. --accept-local option will never
> be passed.
> 
> it seems the test is bogus and can be removed to fix this issue.

Yes, you might want to consider submitting a followup patch that cleans
up the ipv4 route handling against net-next tree.

Acked-by: Florian Westphal <fw@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux