Re: [PATCH libmnl 1/2] socket: introduce mnl_socket_open2()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 2 Oct 2015, Guillaume Nault wrote:

> Define mnl_socket_open2() so that user can pass a set of SOCK_* flags
> at socket creation time.
> 
> Signed-off-by: Guillaume Nault <g.nault@xxxxxxxxxxxx>
> ---
>  include/libmnl/libmnl.h |  3 ++-
>  src/libmnl.map          |  1 +
>  src/socket.c            | 41 ++++++++++++++++++++++++++++++++---------
>  3 files changed, 35 insertions(+), 10 deletions(-)
> 
> diff --git a/include/libmnl/libmnl.h b/include/libmnl/libmnl.h
> index 3a589bc..5adb13c 100644
> --- a/include/libmnl/libmnl.h
> +++ b/include/libmnl/libmnl.h
> @@ -21,7 +21,8 @@ extern "C" {
>  
>  struct mnl_socket;
>  
> -extern struct mnl_socket *mnl_socket_open(int type);
> +extern struct mnl_socket *mnl_socket_open(int bus);
> +extern struct mnl_socket *mnl_socket_open2(int bus, int flags);
>  extern struct mnl_socket *mnl_socket_fdopen(int fd);
>  extern int mnl_socket_bind(struct mnl_socket *nl, unsigned int groups, pid_t pid);
>  extern int mnl_socket_close(struct mnl_socket *nl);
> diff --git a/src/libmnl.map b/src/libmnl.map
> index 3c147a7..e5920e5 100644
> --- a/src/libmnl.map
> +++ b/src/libmnl.map
> @@ -74,5 +74,6 @@ LIBMNL_1.1 {
>  } LIBMNL_1.0;
>  
>  LIBMNL_1.2 {
> +  mnl_socket_open2;
>    mnl_socket_fdopen;
>  } LIBMNL_1.1;

I think this breaks library ABI: you should introduce a new revision 
instead.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux