Re: [PATCH nf-next,v2] netfilter: ctnetlink: remove function inline declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

[auto build test results on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: i386-defconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_conntrack_netlink.c:529:15: warning: 'ctnetlink_proto_size' defined but not used [-Wunused-function]
    static size_t ctnetlink_proto_size(const struct nf_conn *ct)
                  ^
>> net/netfilter/nf_conntrack_netlink.c:546:15: warning: 'ctnetlink_acct_size' defined but not used [-Wunused-function]
    static size_t ctnetlink_acct_size(const struct nf_conn *ct)
                  ^
>> net/netfilter/nf_conntrack_netlink.c:556:12: warning: 'ctnetlink_secctx_size' defined but not used [-Wunused-function]
    static int ctnetlink_secctx_size(const struct nf_conn *ct)
               ^
>> net/netfilter/nf_conntrack_netlink.c:572:15: warning: 'ctnetlink_timestamp_size' defined but not used [-Wunused-function]
    static size_t ctnetlink_timestamp_size(const struct nf_conn *ct)
                  ^

vim +/ctnetlink_proto_size +529 net/netfilter/nf_conntrack_netlink.c

   523	nlmsg_failure:
   524	nla_put_failure:
   525		nlmsg_cancel(skb, nlh);
   526		return -1;
   527	}
   528	
 > 529	static size_t ctnetlink_proto_size(const struct nf_conn *ct)
   530	{
   531		struct nf_conntrack_l3proto *l3proto;
   532		struct nf_conntrack_l4proto *l4proto;
   533		size_t len = 0;
   534	
   535		rcu_read_lock();
   536		l3proto = __nf_ct_l3proto_find(nf_ct_l3num(ct));
   537		len += l3proto->nla_size;
   538	
   539		l4proto = __nf_ct_l4proto_find(nf_ct_l3num(ct), nf_ct_protonum(ct));
   540		len += l4proto->nla_size;
   541		rcu_read_unlock();
   542	
   543		return len;
   544	}
   545	
 > 546	static size_t ctnetlink_acct_size(const struct nf_conn *ct)
   547	{
   548		if (!nf_ct_ext_exist(ct, NF_CT_EXT_ACCT))
   549			return 0;
   550		return 2 * nla_total_size(0) /* CTA_COUNTERS_ORIG|REPL */
   551		       + 2 * nla_total_size(sizeof(uint64_t)) /* CTA_COUNTERS_PACKETS */
   552		       + 2 * nla_total_size(sizeof(uint64_t)) /* CTA_COUNTERS_BYTES */
   553		       ;
   554	}
   555	
 > 556	static int ctnetlink_secctx_size(const struct nf_conn *ct)
   557	{
   558	#ifdef CONFIG_NF_CONNTRACK_SECMARK
   559		int len, ret;
   560	
   561		ret = security_secid_to_secctx(ct->secmark, NULL, &len);
   562		if (ret)
   563			return 0;
   564	
   565		return nla_total_size(0) /* CTA_SECCTX */
   566		       + nla_total_size(sizeof(char) * len); /* CTA_SECCTX_NAME */
   567	#else
   568		return 0;
   569	#endif
   570	}
   571	
 > 572	static size_t ctnetlink_timestamp_size(const struct nf_conn *ct)
   573	{
   574	#ifdef CONFIG_NF_CONNTRACK_TIMESTAMP
   575		if (!nf_ct_ext_exist(ct, NF_CT_EXT_TSTAMP))

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux