Re: [PATCH -next 2/8] netfilter: add and use nf_ct_netns_get/put

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 2015-10-02 13:49, Florian Westphal wrote:
>diff --git a/net/ipv4/netfilter/ipt_SYNPROXY.c b/net/ipv4/netfilter/ipt_SYNPROXY.c
>index 6a6e762..01a2322 100644
>--- a/net/ipv4/netfilter/ipt_SYNPROXY.c
>+++ b/net/ipv4/netfilter/ipt_SYNPROXY.c
>@@ -415,12 +415,12 @@ static int synproxy_tg4_check(const struct xt_tgchk_param *par)
> 	    e->ip.invflags & XT_INV_PROTO)
> 		return -EINVAL;
> 
>-	return nf_ct_l3proto_try_module_get(par->family);
>+	return nf_ct_netns_get(par->net, NFPROTO_IPV4);
> }
> 
> static void synproxy_tg4_destroy(const struct xt_tgdtor_param *par)
> {
>-	nf_ct_l3proto_module_put(par->family);
>+	nf_ct_netns_put(par->net, NFPROTO_IPV4);
> }
> 
> static struct xt_target synproxy_tg4_reg __read_mostly = {

In the other places (like ip6t_SYNPROXY, xt_CONNSECMARK, ..), you chose
par->family, why hardcode NFPROTO_IPV4 in just this place?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux