Re: [PATCH 1/2 nf-next] netfilter: nfnetlink_queue: get rid of nfnetlink_queue_ct.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: m68k-sun3_defconfig (attached as .config)
reproduce:
  wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
  chmod +x ~/bin/make.cross
  git checkout d383b8e3373d12fd234b15f30bdd87b4d2dfc22a
  # save the attached .config to linux build tree
  make.cross ARCH=m68k 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   net/netfilter/nfnetlink_queue_core.c: In function '__nfqnl_enqueue_packet.constprop':
>> net/netfilter/nfnetlink_queue_core.c:518:18: warning: 'nfq_ct' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (ct && nfq_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
                     ^
   net/netfilter/nfnetlink_queue_core.c:316:22: note: 'nfq_ct' was declared here
     struct nfq_ct_hook *nfq_ct;
                         ^

vim +/nfq_ct +518 net/netfilter/nfnetlink_queue_core.c

   502			struct nfqnl_msg_packet_timestamp ts;
   503			struct timeval tv = ktime_to_timeval(entskb->tstamp);
   504			ts.sec = cpu_to_be64(tv.tv_sec);
   505			ts.usec = cpu_to_be64(tv.tv_usec);
   506	
   507			if (nla_put(skb, NFQA_TIMESTAMP, sizeof(ts), &ts))
   508				goto nla_put_failure;
   509		}
   510	
   511		if ((queue->flags & NFQA_CFG_F_UID_GID) && entskb->sk &&
   512		    nfqnl_put_sk_uidgid(skb, entskb->sk) < 0)
   513			goto nla_put_failure;
   514	
   515		if (seclen && nla_put(skb, NFQA_SECCTX, seclen, secdata))
   516			goto nla_put_failure;
   517	
 > 518		if (ct && nfq_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
   519			goto nla_put_failure;
   520	
   521		if (cap_len > data_len &&
   522		    nla_put_be32(skb, NFQA_CAP_LEN, htonl(cap_len)))
   523			goto nla_put_failure;
   524	
   525		if (nfqnl_put_packet_info(skb, entskb, csum_verify))
   526			goto nla_put_failure;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux