On Wed, Sep 16, 2015 at 07:28:36PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Sep 16, 2015 at 07:12:47PM +0200, Jan Engelhardt wrote:
> > Commit libnftnl-1.0.3-31-g5ea54b2 removed a symbol. Such requires a
> > bumped to n+1:0:0.
>
> Right, nft_rule_expr_build_payload() was gone. But noone was using it
> in our tree. But we have to update LIBTOOL version according, yes.
>
> > The symbol groups can be merged again to save time
> > processing them as the groups are relative to a particular SONAME
> > (of which we have a new one).
> >
> > Signed-off-by: Jan Engelhardt <jengelh@xxxxxxx>
> > ---
> > This essentially supersedes "[PATCH libnftnl 0/2] map fixes".
> > The use of LIBNFTNL_4 as a symbol name is modeled upon the LIBVERSION
> > number. Doing this instead of _x.y is a (more) sensible choice,
> > because the next modification to the symbol map (LIBNFTNL_5) needs to
> > be accompanied by LIBVERSION=5:0:something in any case.
> >
> >
> > src/libnftnl.map | 14 ++------------
> > 1 file changed, 2 insertions(+), 12 deletions(-)
> >
> > diff --git a/src/libnftnl.map b/src/libnftnl.map
> > index 14ec88c..991fe9d 100644
> > --- a/src/libnftnl.map
> > +++ b/src/libnftnl.map
> > @@ -1,4 +1,4 @@
> > -LIBNFTNL_1.0 {
> > +LIBNFTNL_4 {
>
> This is breaking hard existing nft binaries, which is what I was
> trying to avoid.
Sorry, what you propose is fine actually. But this should be
LIBNFTNL_3 instead, I already bumped LIBVERSION from 2:0:2 to 3:0:3,
see 9e1e8052025fde.
If no concerns, I'll mangle your patch to make use LIBNFTNL_3 instead.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
