On Tue, Sep 08, 2015 at 10:55:30AM +0200, Jan Engelhardt wrote: > On Tuesday 2015-09-08 09:02, Zaman, Imran wrote: > > >Well! I tend to disagree here.. > > > >Any resource should be freed immediately if it is not in use.. > > Yet they are in use until xtables-main.c:78 or so. This lazy resource approach is sloppy. It's a good practise to release things before leaving the program. By releasing things when we don't need them anymore, we reduce the noise in valgrind and similar tools so it becomes more easily to detect more significant problems in the software. Imran, please fix your patch to avoid the crash that was indicated in first place and resubmit, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
