On 28 August 2015 at 16:57, Simon Horman <simon.horman@xxxxxxxxxxxxx> wrote: > On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote: >> The goal of this series is to allow OVS to send packets through the Linux >> kernel connection tracker, and subsequently match on fields populated by >> conntrack. This functionality is enabled through a new >> CONFIG_OPENVSWITCH_CONNTRACK option. >> >> This version addresses the feedback from v5, primarily checking the behaviour >> is correct with different configurations such as disabling >> CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like >> connlabels. >> >> The branch below has been updated with the corresponding userspace pieces: >> https://github.com/joestringer/ovs dev/ct_20150818 > > Hi Joe, > > Nice work getting this patchset in order. > > I am seeing the following when compiling without NF_CONNTRACK_MARK set. > > CC [M] net/openvswitch//conntrack.o > net/openvswitch//conntrack.c: In function ‘__ovs_ct_update_key’: > net/openvswitch//conntrack.c:127:24: error: ‘const struct nf_conn’ has no member named ‘mark’ > key->ct.mark = ct ? ct->mark : 0; > ^ > net/openvswitch//conntrack.c: In function ‘ovs_ct_set_mark’: > net/openvswitch//conntrack.c:195:26: error: ‘struct nf_conn’ has no member named ‘mark’ > new_mark = ct_mark | (ct->mark & ~(mask)); > ^ > net/openvswitch//conntrack.c:196:8: error: ‘struct nf_conn’ has no member named ‘mark’ > if (ct->mark != new_mark) { > ^ > net/openvswitch//conntrack.c:197:5: error: ‘struct nf_conn’ has no member named ‘mark’ > ct->mark = new_mark; > ^ > scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o' failed > make[1]: *** [net/openvswitch//conntrack.o] Error 1 > Makefile:1386: recipe for target '_module_net/openvswitch/' failed > make: *** [_module_net/openvswitch/] Error 2 Thanks for reporting this, I sent a patch. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
