On Wed, Aug 05, 2015 at 05:51:45PM +0200, Andreas Schultz wrote:
> @@ -478,34 +482,59 @@ int nfnl_acct_overquota(const struct sk_buff *skb, struct nf_acct *nfacct)
> }
> EXPORT_SYMBOL_GPL(nfnl_acct_overquota);
>
> +static int __net_init nfnl_acct_net_init(struct net *net)
> +{
> + INIT_LIST_HEAD(&net->nfnl_acct_list);
> +
> + return 0;
^^^^^^^^
Minor comestic: Please, make sure we get indent as tabs of 8-chars long.
> +}
> +
> +static void __net_exit nfnl_acct_net_exit(struct net *net)
> +{
> + struct nf_acct *cur, *tmp;
> +
> + list_for_each_entry_safe(cur, tmp, &net->nfnl_acct_list, head) {
> + list_del_rcu(&cur->head);
> +
> + if (atomic_dec_and_test(&cur->refcnt))
> + kfree_rcu(cur, rcu_head);
> + }
> +}
You better use nfnl_acct_put() here, otherwise we leak a module
refcount.
Other than that, this looks fine with me. Please send a v2.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
