On Wed, Jul 22, 2015 at 12:54:46PM +0200, Daniel Borkmann wrote: > This patch replaces the zone id which is pushed down into functions > with the actual zone object. It's a bigger one-time change, but > needed for later on extending zones with a direction parameter, and > thus decoupling this additional information from all call-sites. > > No functional changes in this patch. > > The default zones becomes a global const object, namely nf_ct_zone_dflt > and will be returned directly in various cases, one being, when there's > f.e. no zoning support. Looks fine. This patchset depends on the recent fixes though, so let me send a pull request to David with pending nf-next updates, then you can rebase upon a fresh HEAD. Regarding follow up patches, it would be good if you rename CTA_DIR to CTA_ZONE_DIR. If you plan to place more information into the zone extension, then it's probably a good idea to add a new nested CTA_ZONE_INFO attribute where we can start adding new more information on the zone configuration there that applies to the tuple. I have seen also that you placed zone-dir= after use= in the sysctl output, but you can place this after the zone instead. We have a netlink interface so people should not be doing string parsing. I'll make a closer look later to see if I have more comments. Thanks for your patience, Daniel. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
