Re: [ulogd2 PATCHv2] Use stdint types everywhere

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 2015-06-23 at 19:27 +0200, Felix Janda wrote:
> Signed-off-by: Felix Janda <felix.janda@xxxxxxxxx>
> ---
> v2: Ensure that <stdint.h> is included where used. Only the changes 
> to
>     the headers are different from v1.
> ---
...

> @@ -594,14 +594,14 @@ static int _interp_udp(struct 
> ulogd_pluginstance *pi, struct udphdr *udph,
>  
>  /* Section 3.1.  SCTP Common Header Format */
>  typedef struct sctphdr {
> -	__be16 source;
> -	__be16 dest;
> -	__be32 vtag;
> -	__be32 checksum;
> +	uint16_t source;
> +	uint16_t dest;
> +	uint32_t vtag;
> +	uint32_t checksum;
>  } __attribute__((packed)) sctp_sctphdr_t;

Sorry for not mentioning that in previous mail but I'm not comfortable
with this hunk. We are loosing synchronization with upstream definition
as well as some information on endianness.

Could you repost the patch removing this hunk?

BR,
-- 
Eric Leblond <eric@xxxxxxxxx>
Blog: https://home.regit.org/

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux