Hello, On Sun, 14 Jun 2015, Eric W. Biederman wrote: > This patshset roots out all of the very weird network namespace > computation logic (except for the code in ipvs) and fixes it. I really > don't like how the code has been essentially guessing which network > namespace to use. > > Probably the worst guessing is in ipvs in the function skb_net. I have > some preliminary changes to fix ipvs but they are not quite ready yet. > Cleaning up ipvs enough that I can kill skb_net is on my short list. For IPVS skb_net is too complicated. One of the first things we do in hook handler is to check skb_dst, so even now dev_net(skb_dst(skb)->dev) should work. sock_net is used for administration via netlink, skb_net is not used there (ip_vs_ctl.c). As for removing/replacing skb_net, ip_vs_conn_net() is ok when cp is present, we have also svc->net, otherwise we can store net into struct ip_vs_iphdr, it is filled by ip_vs_fill_iph_skb from small number of places when hook handler is entered. Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
