On Mon, Jun 15, 2015 at 10:06:27AM -0500, Eric W. Biederman wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> writes: > > > Hi Eric, > > > > On Sun, Jun 14, 2015 at 10:07:30PM -0500, Eric W. Biederman wrote: > >> > >> While looking into what it would take to route packets out to network > >> devices in other network namespaces I started looking at the netfilter > >> hooks, and there is a lot of nasty code to figure out which network > >> namespace to filter the packets in. > >> > >> Just passing the network namespace into the netfilter hooks looks like a > >> significant simplication in the code, and worth it as the first thing > >> most netfilter hooks do is compute the network namespace. > >> > >> We probably even want per network namespace netfilter hooks as nftables > >> tries (and fails to use). nftables currently has a fairly serious bug > >> where the tables for one network namespace run for packets in all > >> network namespaces. I do not have a fix yet but I think this patchset > >> making it easy to get at the network namespace is a good starting > >> place for a fix. > > > > I have a patchset that is almost ready to convert netfilter to pernet > > hooks, it partially clashes with this. Will send it out today and will > > Cc you so you can review it. > > > > I think it should take me little time to rebase it on top of yours. > > It's rather large changeset, which quite a lot of boiler plate code > > though. > > Hmm. > > I will wait and take a look. I think going from where I am to pernet > netfilter hooks is about one simple patch, so I don't know where the > large about of boiler plate comes from. You have to register the struct nf_hook_ops for each nf_register_hooks() caller from the pernet .init. > I think I will code that up so I can verify that and we can compare > notes later today. This is basically done here, I'll post this asap. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
