The FIXME was related to exclusion of string types from cmp length checks. Since with fixed sized helper names the last case where this could happen is gone, remove the FIXME and perform length checks on strings as well. Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx> --- src/netlink_delinearize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c index ec1a964..b23d587 100644 --- a/src/netlink_delinearize.c +++ b/src/netlink_delinearize.c @@ -166,9 +166,7 @@ static void netlink_parse_cmp(struct netlink_parse_ctx *ctx, nld.value = nft_rule_expr_get(nle, NFT_EXPR_CMP_DATA, &nld.len); right = netlink_alloc_value(loc, &nld); - // FIXME - if (left->len && left->dtype && left->dtype->type != TYPE_STRING && - left->len != right->len) + if (left->len != right->len) return netlink_error(ctx, loc, "Relational expression size mismatch"); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
