On Thu, 7 May 2015, Pablo Neira Ayuso wrote:
> On Sat, May 02, 2015 at 07:27:59PM +0200, Jozsef Kadlecsik wrote:
> > Signed-off-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>
> > ---
> > net/netfilter/ipset/ip_set_hash_gen.h | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/netfilter/ipset/ip_set_hash_gen.h b/net/netfilter/ipset/ip_set_hash_gen.h
> > index 91e5327..69f2b25 100644
> > --- a/net/netfilter/ipset/ip_set_hash_gen.h
> > +++ b/net/netfilter/ipset/ip_set_hash_gen.h
> > @@ -1095,10 +1095,12 @@ mtype_list(const struct ip_set *set,
> >
> > pr_debug("list hash set %s\n", set->name);
> > t = (const struct htable *) cb->args[IPSET_CB_PRIVATE];
> > + /* Expire may replace a hbucket with another one */
> > + rcu_read_lock();
>
> You should have rebase the previous patches to fix this from the
> original patchset.
Yes, you are right: there were several fixes integrated into the RCU
patches, this one was forgotten somehow.
> I don't think it was good idea to keep this large patchset in the
> queue, specially with the RCU patches. They are rather critical, and
> many follow up not so important patches follow up later on.
>
> I will come back to review the rcu patches, I still have concerns
> there.
>
> If you're OK, I'll take as much as I can that is independent your RCU
> changes, so you don't need to resend this large patchset, but you will
> need to rebase though.
>
> Sorry.
OK. Too much patch queued up, that's right.
Best regards,
Jozsef
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
