On Thu, May 07, 2015 at 08:19:18PM +0200, Pablo Neira Ayuso wrote: [...] > I will come back to review the rcu patches, I still have concerns > there. > > If you're OK, I'll take as much as I can that is independent your RCU > changes, so you don't need to resend this large patchset, but you will > need to rebase though. Unless you have any concern, I'm going to start by applying this batch of 15 patches: netfilter: ipset: Use better include files in xt_set.c netfilter: ipset: Improve preprocessor macros checks netfilter: ipset: Fix hashing for ipv6 sets netfilter: ipset: Fix ext_*() macros netfilter: ipset: Check for comment netlink attribute length netfilter: ipset: Return bool values instead of int netfilter: ipset: Use HOST_MASK literal to represent host address CIDR len netfilter: ipset: Check IPSET_ATTR_PORT only once netfilter: ipset: Return ipset error instead of bool netfilter: ipset: Preprocessor directices cleanup netfilter: ipset: No need to make nomatch bitfield netfilter: ipset: Properly calculate extensions offsets and total length netfilter: ipset: make ip_set_get_ip*_port to use skb_network_offset netfilter: ipset: Give a better name to a macro in ip_set_core.c netfilter: ipset: Fix sparse warning It would be good if other small patches come in first place if possible. Otherwise, I'd suggest you focus on a next batch with the rcu conversion, that will be already quite large. Thanks Jozsef. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html