[PATCH] nf_tables: silence needless warning on element delete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When deleting nft set elements in certain situations, a warning was triggered
by wrong check for dtype value. This fixes the check accordingly to enum
definition in include/linux/netfilter/nf_tables.h

Signed-off-by: Mirek Kratochvil <exa.exa@xxxxxxxxx>

Ref.: https://bugzilla.netfilter.org/show_bug.cgi?id=1013
---
 net/netfilter/nf_tables_api.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index adce01e..f2653a5 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -3312,9 +3312,8 @@ EXPORT_SYMBOL_GPL(nft_data_init);
  */
 void nft_data_uninit(const struct nft_data *data, enum nft_data_types type)
 {
+    if (type < NFT_DATA_VERDICT) return;
     switch (type) {
-    case NFT_DATA_VALUE:
-        return;
     case NFT_DATA_VERDICT:
         return nft_verdict_uninit(data);
     default:
-- 
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux