Re: [PATCH RFC 0/2] nftables: fix time parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 11, 2015 at 03:00:28PM +0100, Patrick McHardy wrote:
> These patches attempt to fix time parsing to not require quotation marks
> around the time spec and loosen the checks so times can also be specified
> in smaller units.
> 
> Some testing indicates it works fine, however I'd put them into a branch
> for 4.1 since I mainly need this fixed for the set timeout support.

Thanks, this looks fine to me.

I still think that we need to consider flex start conditions or
something similar to make the scanner a bit smarter (stateful) to
avoid complexity on the parser.

I think that may also help to avoid the side issue related to this
patch:

http://patchwork.ozlabs.org/patch/443091/

Basically, the scanner takes this:

tcp sport vmap { 25:accept, 28:drop };ok
                 ^^^^^

as a tc handle.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux