On 04/10/2015 02:15 PM, Pablo Neira Ayuso wrote:
This patch splits __netif_receive_skb_core() in smaller functions to improve maintainability. The function __netif_receive_skb_core() has been split in two: * __netif_receive_skb_ingress(), to perform all actions up to ingress filtering. * __netif_receive_skb_finish(), if the ingress filter accepts this packet, pass it to the corresponding packet_type function handler for further processing. This patch also adds __NET_RX_ANOTHER_ROUND that is used when the packet is stripped off from the vlan header or in case the rx_handler needs it. This also prepares the introduction of the netfilter ingress hook.
Out of curiosity, what is actually the performance impact on all of this? We were just arguing on a different matter on two more instructions in the fast-path, here it's refactoring the whole function into several ones, I presume gcc won't inline it. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html