On Wed, Apr 8, 2015, at 04:13, David Miller wrote: > From: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx> > Date: Wed, 08 Apr 2015 01:24:59 +0200 > > > There is one small problem which already was present before this patch > > because of my change b6a7719aedd7e5 ("ipv4: hash net ptr into > > fragmentation bucket selection"). It uses sock_net in iptunnel_xmit, > > which causes a NULL ptr panic. This patchset did make it more visible > > because of the explicit NULL passing but the bug was introduced by my > > patch. > > > > Just wanted to let you know if reports are coming in - I fix it up > > tomorrow. I will also explore the possibility to give each tunnel at > > least a raw socket, what Tom proposed. > > > > Rick Jones identified this, thanks! > > Looking into this I also notice that ipip6_tunnel_xmit() passes > in skb->sk, that needs to be NULL too. > > Want to take care of that along with your sock_net() fix? Yep, did so and used the simple solution for now. I am currently trying to check if it makes sense to remove ignore_df and always use the socket context. Bye, Hannes -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html