Re: Re: [PATCH V3 1/2] Add revision field for xt_entry_target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi pablo

>From: Pablo Neira Ayuso
>Date: 2015-03-26
>To: Zhang, Chunyu/章 春宇
>Subject: Re: [PATCH V3 1/2] Add revision field for xt_entry_target
>
>On Thu, Mar 26, 2015 at 05:33:29AM -0400, Zhang Chunyu wrote:
>> ---
>>  arptables.c                              | 2 ++
>>  extensions/arpt_CLASSIFY.c               | 1 +
>>  extensions/arpt_mangle.c                 | 1 +
>>  extensions/arpt_standard.c               | 1 +
>>  include/arptables.h                      | 6 ++++++
>>  include/linux/netfilter_arp/arp_tables.h | 3 ++-
>>  6 files changed, 13 insertions(+), 1 deletion(-)
>>
>[...]
>> diff --git a/include/linux/netfilter_arp/arp_tables.h b/include/linux/netfilter_arp/arp_tables.h
>> index 0acda66..0bf2457 100644
>> --- a/include/linux/netfilter_arp/arp_tables.h
>> +++ b/include/linux/netfilter_arp/arp_tables.h
>> @@ -19,7 +19,7 @@
>> 
>>  #include <linux/netfilter_arp.h>
>> 
>> -#define ARPT_FUNCTION_MAXNAMELEN 30
>> +#define ARPT_FUNCTION_MAXNAMELEN 29
>>  #define ARPT_TABLE_MAXNAMELEN 32
>> 
>>  #define ARPT_DEV_ADDR_LEN_MAX 16
>> @@ -69,6 +69,7 @@ struct arpt_entry_target
>> 
>>                       /* Used by userspace */
>>                       char name[ARPT_FUNCTION_MAXNAMELEN];
>> +                     u_int8_t revision;
>>               } user;
>>               struct {
>>                       u_int16_t target_size;
>
>Could you also resubmit the kernel patch to adds this? Please, no need
>to resend the full userspace series, just send the kernel patch as a
>follow up.

do you mean:
> -#define ARPT_FUNCTION_MAXNAMELEN 30

> +#define ARPT_FUNCTION_MAXNAMELEN 29
do this in another  patch ,  like this ?
patch1:  change ARPT_FUNCTION_MAXNAMELEN
patch2:  add revision
patch3:  add arp mark��.n��������+%������w��{.n����z��׫���n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux