On 25 March 2015 at 21:04, Julian Anastasov <ja@xxxxxx> wrote:
>
> Hello,
>
> On Wed, 25 Mar 2015, Rafał Miłecki wrote:
>
>> Including net/ip_vs.h without CONFIG_IP_VS was causing:
>> include/net/ip_vs.h: In function 'net_ipvs':
>> include/net/ip_vs.h:35:12: error: 'struct net' has no member named 'ipvs'
>>
>> Fixes: 8b4d14d8eb368 ("netns: exclude ipvs from struct net when IPVS disabled")
>> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
>> ---
>> V2: Disable function totally instead of returning NULL.
>
> While this version is better, the commit message
> looks scary, it should explain that problem happens only
> for modules out of kernel tree, we do not want other admins
> to wonder whether they need this commit for their trees.
OK, I just need some decision if you want/need this patch at all and
if I should send another version.
> And of course, it is better to implement your
> own ip_vs_check_diff4 version, it is some inline stuff...
I did.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
