hi pablo >From: netfilter-devel-owner >Date: 2015-03-18 >To: Zhang, Chunyu/章 春宇 >Subject: Re: [PATCH 1/3] Add revision field for xt_entry_target > >On Wed, Mar 18, 2015 at 02:47:33AM +0000, Zhang, Chunyu wrote: >> >> diff --git a/include/linux/netfilter_arp/arp_tables.h b/include/linux/netfilter_arp/arp_tables.h >> >> index 0acda66..ccf8cd0 100644 >> >> --- a/include/linux/netfilter_arp/arp_tables.h >> >> +++ b/include/linux/netfilter_arp/arp_tables.h >> >> @@ -19,7 +19,7 @@ >> >> >> >> #include <linux/netfilter_arp.h> >> >> >> >> -#define ARPT_FUNCTION_MAXNAMELEN 30 >> >> +#define ARPT_FUNCTION_MAXNAMELEN 29 >> >> #define ARPT_TABLE_MAXNAMELEN 32 >> >> >> >> #define ARPT_DEV_ADDR_LEN_MAX 16 >> >> @@ -69,6 +69,8 @@ struct arpt_entry_target >> >> >> >> /* Used by userspace */ >> >> char name[ARPT_FUNCTION_MAXNAMELEN]; >> >> + >> >> + u_int8_t revision; >> > >> >This structure is not exposed to userspace and I don't find any client >> >of it in this code: >> > >> >include/uapi/linux/netfilter_arp/arp_tables.h:#define arpt_entry_target xt_entry_target >> > >> >and arp_tables uses xt_entry_target all the time. >> >> revision is used to mark_tg in kernel file : kernel-3.14/net/netfilter/xt_mark.c > >Forget it, I got confused by the net/netfilter/xt_repldata.h trickery, >sorry. Please, resubmit this patch once you have extended the >userspace arp mark extension to exactly mirror what mark can do in >iptables/ip6tables. ok, i will do it for revision also add --and-mark and --or-mark maybe too many code to add. > >Thanks. >-- >To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html��.n��������+%����;��w��{.n����z�����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
