Re: [PATCH next] netfilter: fix sparse warnings in reject handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 09, 2015 at 11:04:15PM +0100, Florian Westphal wrote:
> make C=1 CF=-D__CHECK_ENDIAN__ shows following:
> 
> net/bridge/netfilter/nft_reject_bridge.c:65:50: warning: incorrect type in argument 3 (different base types)
> net/bridge/netfilter/nft_reject_bridge.c:65:50:    expected restricted __be16 [usertype] protocol [..]
> net/bridge/netfilter/nft_reject_bridge.c:102:37: warning: cast from restricted __be16
> net/bridge/netfilter/nft_reject_bridge.c:102:37: warning: incorrect type in argument 1 (different base types) [..]
> net/bridge/netfilter/nft_reject_bridge.c:121:50: warning: incorrect type in argument 3 (different base types) [..]
> net/bridge/netfilter/nft_reject_bridge.c:168:52: warning: incorrect type in argument 3 (different base types) [..]
> net/bridge/netfilter/nft_reject_bridge.c:233:52: warning: incorrect type in argument 3 (different base types) [..]
> 
> Caused by two (harmless) errors:
> 1. htons() instead of ntohs()
> 2. __be16 for protocol in nf_reject_ipXhdr_put API, use u8 instead.

Applied, thanks. I'll pass to David a small pull request to focus on
resolving the existing issues first.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux