From: Florian Westphal <fw@xxxxxxxxx> Date: Mon, 9 Mar 2015 18:35:15 +0100 > David Miller <davem@xxxxxxxxxx> wrote: >> > The 2nd (and last half) of the set folds nf_bridge_info into skbuff, >> > at the end (where its not initialized at allocation time). >> > >> > The struct is a lot smaller by then (16 bytes on 64bit, 12 on 32bit) >> > so we'd increase skbuff size only by 8. >> >> Sorry, increases in size of any kind of sk_buff are strongly discouraged. > > No need to be sorry, its not a show-stopper. > Its the last patch in the series and nothing depends on this change. > >> Especially for something like nfbridge. > > Its not initialized, ever, if bridge is not used, so it shouldn't be a big > deal. It's about the overall size of the structure, not whether the member is ever used or not. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
