On Tue, Mar 03, 2015 at 08:04:19PM +0000, Patrick McHardy wrote: > Check that the space required for the expressions doesn't exceed the > size of the dlen field, which would lead to the iterators crashing. > > Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx> > --- > net/netfilter/nf_tables_api.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c > index 6fb532b..7baafd5 100644 > --- a/net/netfilter/nf_tables_api.c > +++ b/net/netfilter/nf_tables_api.c > @@ -1968,6 +1968,10 @@ static int nf_tables_newrule(struct sock *nlsk, struct sk_buff *skb, > n++; > } > } > + /* Check for overflow of dlen field */ > + err = -EFBIG; Should we use -EOVERFLOW instead as we use in other nf_tables spots? The error in userspace will be: "Value too large for defined data type". > + if (size >= 1 << 12) > + goto err1; > > if (nla[NFTA_RULE_USERDATA]) > ulen = nla_len(nla[NFTA_RULE_USERDATA]); > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
