Re: [PATCH nft 1/2] src: complete meta priority support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24.02, Pablo Neira Ayuso wrote:
> This patch adds the missing bits to scan and parse the meta priority
> string. The output code to list it has been also reworked.
> 
> To match the skbuff priority you can use:
> 
>  nft add rule filter forward meta priority :ffff
>  nft add rule filter forward meta priority ffff:
>  nft add rule filter forward meta priority abcd:1234
> 
> and to set it, you can use:
> 
>  nft add rule filter forward meta priority set abcd:1234
> 
> flex performs longest prefix matching when scanning patterns so there is
> not conflict with IPv6 addresses.
> 
> There's still a possible clash with:
> 
> 	nft add rule filter input tcp dport vmap { 25:accept, 28:drop }
> 
> where "25:acce" and "28:d" are interpreted as a meta priority.
> 
> I think it's reasonable to tell people that they have to separate the
> key and the data that represent the element tuple with a whitespace
> separator between the colon, at least until we find a better way to
> handle this.

I agree that it's not too bad, but still would be preferable to avoid
this.

> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> ---
> @Patrick: You proposed an alternative to this time ago:
> 
> http://patchwork.ozlabs.org/patch/320066/
> 
> but after applying a similar patch here, that seem to break many other
> stuff according to the nft-test.py regression tests.

Out of interest, what does it break?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux