On 12 February 2015 at 13:20, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > On Thu, Feb 12, 2015 at 11:14:09AM +0100, Arturo Borrero Gonzalez wrote: >> >> net/netfilter/nft_compat.c:140:37: sparse: incorrect type in assignment (different base types) >> net/netfilter/nft_compat.c:140:37: expected restricted __be16 [usertype] ethproto >> net/netfilter/nft_compat.c:140:37: got unsigned char [unsigned] [usertype] proto >> >> net/netfilter/nft_compat.c:351:37: sparse: incorrect type in assignment (different base types) >> net/netfilter/nft_compat.c:351:37: expected restricted __be16 [usertype] ethproto >> net/netfilter/nft_compat.c:351:37: got unsigned char [unsigned] [usertype] proto > > This is spotting a more serious problem. The existing code is trimming > the ethernet protocol field to u8. We should use u16 all around the > code and then force the casting to calm down sparse. > I see, I can handle it if you want. -- Arturo Borrero González -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
