On 02/09/15 at 07:48pm, Josh Hunt wrote: > if ((params->key_len && !params->hashfn) || > - (!params->key_len && !params->obj_hashfn)) > + (!params->key_len && !params->obj_hashfn) || > + (!params->max_shift)) > return -EINVAL; You can drop the parenthesis around the new max_shift check. Other than that: Acked-by: Thomas Graf <tgraf@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html