On Wed, Jan 21, 2015 at 04:08:19PM +1100, Herbert Xu wrote: > > OK I think I have a solution for you guys. But first you'll need to > wait for me to undo the nulls stuff so I can steal that bit which > is central to my solution. > > Essentially I need a bit to indicate an entry in the bucket chain > should be skipped, either because it has just been removed or that > it is a walker entry (see xfrm_state_walk). > > The way it'll work then is exactly the same as xfrm_state_walk, > except that the linked list is broken up into individual buckets. > > Of course we'll still need to postpone resizes (and rehashes which > is what my work is about) during a walk but I think that's a fair > price to pay. I failed to address the security aspect of this approach. Obviously this can only work if the only entites doing the walk are trusted. Which means that the vast majority (if not all) hash table users would be excluded, in particular, netlink. Even with trusted cases such as netfilter I'm uneasy about this so I don't think I'm going to go forward with this approach. At this point I think the best thing that'll give you stable dumps is a separate list like xfrm_state_walk. If you did that then we don't need to touch rhashtable at all. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
