From: Patrick McHardy > On 20.01, Thomas Graf wrote: > > Lock out table resizes while dumping Netlink sockets to user space. > > This keeps disruptions to a minimum for readers which don't handle > > the NLM_F_DUMP_INTR flag. > > This doesn't lock them out for the duration of the entire dump of > course, so the benefit seems rather small. Still with this patch, > they will need to handle NLM_F_DUMP_INTR or will get unpredictable > behaviour, in which case I'd think it makes more sense to not even > try this, all it does is hide parts of the brokenness. > > An alternative would be to set a flag in ht when a dump begins that > indicates to skip resizing operations and on the end of the dump > perform any resizing operations that might be necessary. Herbert > disagrees though and he might be right. Can you rely on being told when the dump completes? If the program is killed in the middle then it can't tell you. I suspect you'd have to suppress resize for some time interval after a partial dump. Unfortunately two continuous dumps would be likely to suppress it forever. Maybe sleep user space dump requests for the first block while any resize (esp. grow) is pending. What is passed to userspace as the 'continue from here' marker? Even without resize there are likely to be issues if something nearer the head of a hash chain being processed is deleted. David -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
