On 01/16/15 at 06:36pm, Patrick McHardy wrote: > On 16.01, Thomas Graf wrote: > > On 01/16/15 at 04:43pm, David Laight wrote: > > > The walker is unlikely to see items that get inserted early in the hash > > > table even without a resize. > > > > I don't follow, you have to explain this statement. > > > > Walkers which don't want to see duplicates or miss entries should > > just take the mutex. > > Well, we do have a problem with interrupted dumps. As you know once > the netlink message buffer is full, we return to userspace and > continue dumping during the next read. Expanding obviously changes > the order since we rehash from bucket N to N and 2N, so this will > indeed cause duplicate (doesn't matter) and missed entries. Right,but that's a Netlink dump issue and not specific to rhashtable. Putting the sequence number check in place should be sufficient for sets, right? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
