Am 12.01.2015 um 17:04 schrieb Eric Dumazet: > On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote: >> Signed-off-by: Richard Weinberger <richard@xxxxxx> >> --- >> include/linux/netfilter/x_tables.h | 22 ++++++++++++++++++++++ >> net/ipv4/netfilter/arp_tables.c | 28 +++++++++++++++++----------- >> net/ipv4/netfilter/ip_tables.c | 15 +++++---------- >> net/ipv6/netfilter/ip6_tables.c | 18 +++++++----------- >> net/netfilter/xt_physdev.c | 9 ++------- >> 5 files changed, 53 insertions(+), 39 deletions(-) > > Richard, I dislike this, sorry. That's fine, the series carries the "RFC" burning mark for a reason. > iptables is already horribly expensive, you add another expensive step > for every rule. Yeah, you mean the extra unlikey() check? > device aliasing can be done from user space. How? I did this series because I'm not so happy with the device renaming what udev does. The idea was to offer udev a better kernel interface to deal with aliases. Such that one can use the regular names form the kernel and the predictable names generated from udev. For block devices it was easy, we have the good old symlink. For network interface the kernel does not offer an API. > iptables should have used ifindex, its sad we allowed the substring > match in first place. Maybe nftables can do better. :-) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
