On 08.01, Pablo Neira Ayuso wrote: > pr_debug() is disabled with --with-mini-gmp since it relies on the > gmp_printf(), which is not available in the mini-gmp implementation. > Use printf() instead of pr_debug() if no mpz_t types are used, so > we get debugging information for proto-ctx as well. > > This leaves the pr_debug() usage limited to src/segtree.c. I don't think this patch is conceptually good. The intention of pr_debug() is to be able to disable debugging at compile time to avoid ifdefs everywhere. We currently need them for external debugging functions like mnl, but f.i. in proto_ctx_debug() the compiler should very well be able to determine that the function is a NOP without debugging enabled. I'd rather change pr_debug to a normal printf and adapt segtree to use a pr_gmp_debug or something like that. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
