On Fri, Dec 12, 2014 at 06:36:13PM +0000, Patrick McHardy wrote: > On 12.12, Pablo Neira Ayuso wrote: > > On Fri, Dec 12, 2014 at 05:27:03PM +0000, Patrick McHardy wrote: > > > Am 12. Dezember 2014 17:02:04 GMT+00:00, schrieb Arturo Borrero Gonzalez <arturo.borrero.glez@xxxxxxxxx>: > > > > > > > >Do you want me to change the syntax? I can do it this weekend. Just > > > >let me know :-) > > > > > > Well, I don't think the colon is really bad, however it suggests an > > > address can be put in front of it. I guess the reason is an > > > ambiguity in the grammar with following expressions otherwise. Even > > > though redirect is terminal the grammar so far doesn't know about > > > it. From a readability POV I like a simple "to". > > > > I also like "to". Patch attached to address this. > > > > > >If you are going to change it yourself, I would suggest to also update > > > >regression tests [0], which BTW seems broken due to the > > > >random-fully/fully-random change. > > > > > > I missed that, will fix it up later. > > > > No problem, just fixed it here, will push it now. > > Great, thanks. > > I'll push my concat changes soon unless I hear objections :) Thanks Patrick. Let's release 0.4, OK? Do you want to include your concat changes already in this release? P.S: It's great to see concat extension finally landing, that's a killer feature :-). -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
