Re: [nft PATCH] scanner: fix reading of really long line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,
Le 1 déc. 2014 12:55, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> a écrit :
>
> On Sat, Nov 29, 2014 at 05:24:38PM +0100, Eric Leblond wrote: 
> > Current code is causing a failure in adding a set containing 
> > a really long list of elements. The failure occurs as soon as 
> > the line is longer than flex read buffer. 
> > 
> > When a line is longer than scanner buffer size, the code in YY_INPUT 
> > forces a rewind to the beginning of the string because it does not 
> > find a end of line. The result is that the string is never parsed. 
> > 
> > This patch updates the code by rewinding till we found a space. 
>
> But the part that didn't fit in will be ignore, right? So the user 
> will lose some elements in the set? 

This is not the case as there is a fseek below to rewind at the correct position. So next read get the data from the correct point.

BR,

> If so, I think it's better to spot an error via YY_FATAL_ERROR to 
> indicate that the line is too long to the user. ��.n��������+%������w��{.n����z��׫���n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux