On Mon, Nov 24, 2014 at 07:27:40PM +0100, Arturo Borrero Gonzalez wrote: > On 20 November 2014 at 13:20, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > >> diff --git a/iptables/xtables-eb-standalone.c b/iptables/xtables-eb-standalone.c > >> index 1c3cbf0..740a420 100644 > >> --- a/iptables/xtables-eb-standalone.c > >> +++ b/iptables/xtables-eb-standalone.c > >> @@ -84,7 +84,7 @@ int xtables_eb_main(int argc, char *argv[]) > >> ret = nft_commit(&h); > >> > >> if (!ret) > >> - fprintf(stderr, "%s\n", nft_strerror(errno)); > >> + xtables_error(OTHER_PROBLEM, "%s\n", nft_strerror(errno)); > > > > IIRC error reporting in ebtables differs from iptables. The output > > should look the same. We're currently using nft_strerror() but I guess > > we'll need a ebt_strerror() function. > > > > I've tried to collect ebtables original errors. Most of them uses > arguments, for example: > * Can't delete the chain 'test', it's referenced in chain 'FORWARD', rule 0. > * Loop from chain 'test2' to chain 'test'. > > So, that ebt_strerror() function seems almost useless. > > I will resend this patch with the changes you requested. I guess we > can revisit that issue in the future. Sure, please go ahead. Just document limitations, just in case we revisit this later on. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
